Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge canary to main #1686

Merged
merged 18 commits into from
Jan 13, 2025
Merged

Merge canary to main #1686

merged 18 commits into from
Jan 13, 2025

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

Related issues

Checklist

@krzysztofzuraw krzysztofzuraw requested review from a team as code owners January 13, 2025 09:41
@krzysztofzuraw krzysztofzuraw requested review from a team and witoszekdev January 13, 2025 09:41
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 9fc9edf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
products-feed Patch
@saleor/apps-logger Patch
klaviyo Patch
segment Patch
app-avatax Patch
cms-v2 Patch
search Patch
smtp Patch
@saleor/react-hook-form-macaw Patch
@saleor/webhook-utils Patch
@saleor/apps-shared Patch
@saleor/apps-otel Patch
@saleor/trpc Patch
@saleor/e2e Patch
@saleor/apps-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:59am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:59am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:59am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:59am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:59am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
saleor-app-segment ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:59am

poulch
poulch previously approved these changes Jan 13, 2025
node-version-file: ".nvmrc"
cache: "pnpm"
- name: Install dependencies
run: pnpm install --frozen-lockfile --filter=app-avatax
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we hardcode avatax here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we currently have only e2e for AvaTax app - so it doesn't make sense to install app other deps


/apps/avatax @saleor/shopex-js
/apps/segment @saleor/shopex-js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably merchant should own this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question - I will update after 1st version release

@lkostrowski lkostrowski merged commit 9bbf9ee into main Jan 13, 2025
17 checks passed
@lkostrowski lkostrowski deleted the canary branch January 16, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: AvaTax App: CMS App: Klaviyo App: Product Feed App: Search App: SMTP skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants